Make Events.Move and Events.Scroll more consistent

[nvh]

Events.Move is used:

• When dragging a draggable
• When dragging a ScrollComponent
• When animating a PageComponent

Events.Scroll is used

• When scrolling a ScrollComponent

We need a way to make these more consistent, because now it,s pretty confusing, as #209 shows.

Suggestion:

• Events.Move fires in all the above cases
• Events.DragMove fires when the layer is dragged
• Events.Scroll fires when a layer is scrolled (also when animating and in PageComponent)

[koenbok]

This makes a lot of sense.

[jonastreub]

This is a great update. We need to communicate this change with our users as this might break a lot of existing prototypes

[nvh]

@jonastreub What kind of stuff you think is most common that will break in with this update?

[jordandobson]

Isn’t this all additive? I wouldn’t expect existing prototypes to have issues unless they were targeting these events and then never did anything with them?

Or wait… do we want .move on a scroll component or is move on the content layer?

I really do like have scroll work on the parent / root component instead of the content layer. That seems more sensible and obvious for beginners.

On Mon, Aug 15, 2016 at 2:01 AM, Niels van Hoorn notifications@github.com wrote:

@jonastreub https://github.com/jonastreub What kind of stuff you think is most common that will break in with this update?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/koenbok/Framer/issues/396#issuecomment-239758150, or mute the thread https://github.com/notifications/unsubscribe-auth/AACbYpqpXM5yObWmiG5gGGpBEOWAH8cTks5qgCrNgaJpZM4Ja_KJ .

Jordan Dobson • Designer / Developer • 425-444-8014 • JordanDobson.com

[koenbok]

They're always both @jordandobson