search

koenderks / rcityviews

rcityviews is a user-friendly R interface for creating stylized city maps using OpenStreetMap (www.openstreetmap.org) data, implemented as an R package and a Shiny web application.
https://koenderks.github.io/rcityviews/
GNU General Public License v3.0
163 stars 22 forks source link

Compact package source code #22

Closed SpatLyu closed 3 months ago

SpatLyu commented 3 months ago

I want to submit some PR to reduce the package size (i.e. reduce the size of the images that come with the package). If this step offends you, please let me know.

SpatLyu commented 3 months ago

On my personal PC, the package didn't complete installation for a long time, and I tried to submit a PR after simplifying the package contents

version
#>                _                                
#> platform       x86_64-w64-mingw32               
#> arch           x86_64                           
#> os             mingw32                          
#> crt            ucrt                             
#> system         x86_64, mingw32                  
#> status                                          
#> major          4                                
#> minor          4.1                              
#> year           2024                             
#> month          06                               
#> day            14                               
#> svn rev        86737                            
#> language       R                                
#> version.string R version 4.4.1 (2024-06-14 ucrt)
#> nickname       Race for Your Life

Created on 2024-07-23 with reprex v2.1.1

koenderks commented 3 months ago

Hi @SpatLyu,

You are of course free to improve the package! I do not see any PR from you though, is that still relevant?

SpatLyu commented 3 months ago

I found an installation problem on windows, so I'm ready to reopen an issue

koenderks commented 3 months ago

OK go ahead, hopefully I have some time to look at it in the next day or so!