koenkooi / multiwii-firmware

Firmware - GitHub mirror of the official SVN multiwii project
https://github.com/multiwii/multiwii-firmware/wiki
13 stars 1 forks source link

rcSerialCount might be too low #16

Open koenkooi opened 10 years ago

koenkooi commented 10 years ago

Arne reported seeing the throttle spike to 1500 every now and then and I noticed the same on my hex.

Arne-W commented 10 years ago

Could it be possible that you changed rcSerialCount at the wrong location?? You increased the value in the " MSP_SET_RAW_RC" case but it has to be changed in the "MSP_SET_RAW_RC_TINY" one. By the way I increased the value to 80 cause there were seldom spinups left. But why dont we increase the value to 200 or disable the counter. I dont see any useful effect for flexbot users.

koenkooi commented 10 years ago

You are right, I changed the wrong one. I'm hesitant to disable it since I want to change as little upstream code as possible.

Arne-W commented 10 years ago

Allright - very good. The value of 100 seems to be OK. As metioned above I used 80 and draw a Graph of the value over time and it seems to be safe. So 100 will surely do the trick!