search

koenkooi / multiwii-firmware

Firmware - GitHub mirror of the official SVN multiwii project
https://github.com/multiwii/multiwii-firmware/wiki
13 stars 1 forks source link

Decide what to do with POCKET_QUAD #5

Closed koenkooi closed 10 years ago

koenkooi commented 10 years ago

The flexbot patch adds a POCKET_QUAD config that doesn't match the flexbot. I wonder if we should delete it, or rename it and fix it properly.

I should receive both a hex and a quad soon (fingers crossed!).

gromain commented 10 years ago

I reckon I would keep the POCKET_QUAD configuration, and create a new one for the flexbot quad. I think this is better because we'll keep the compatibility with Multiwii for future upgrades. Or, find where the POCKET_QUAD comes from, and keep it if it represents the Flexbot Quad. On Apr 18, 2014 2:05 PM, "Koen Kooi" notifications@github.com wrote:

The flexbot patch adds a POCKET_QUAD config that doesn't match the flexbot. I wonder if we should delete it, or rename it and fix it properly.

I should receive both a hex and a quad soon (fingers crossed!).

— Reply to this email directly or view it on GitHubhttps://github.com/koenkooi/multiwii-firmware/issues/5 .

koenkooi commented 10 years ago

It comes from the patch I extracted from the flexbot sources. I've fixed the config to match the flexbot quad this morning, so I guess I should rename it for clarity now :)

koenkooi commented 10 years ago

POCKET_QUAD can be dropped, the same define can be used for the quad and hex, only #define QUADX or #define HEX6X are needed