search

koenrh / dnscontrol-action

Deploy your DNS configuration using GitHub Actions using DNSControl.
ISC License
79 stars 37 forks source link

Bump DNSControl to v4.4.1 #108

Closed admdly closed 9 months ago

admdly commented 11 months ago

Closes #106.

Linus9000 commented 11 months ago

I tested this PR in my repository and can confirm that it works. I'd love to see this merged 👍

Phobetor commented 10 months ago

@admdly could you bump further to 4.6.0? The newer versions also contain useful fixes.

Many thanks in advance!

admdly commented 9 months ago

@admdly could you bump further to 4.6.0? The newer versions also contain useful fixes.

Many thanks in advance!

Apologies for not responding sooner - I have since moved to using the official DNSControl Docker images as these are updated much more frequently and work just as well in GitHub Actions.

You could, for example, replace a check workflow using this action with something like (depending on the location of your DNS files):

name: Check

on: pull_request

jobs:
  check:
    runs-on: ubuntu-latest
    container:
      image: stackexchange/dnscontrol:latest
    steps:
      - uses: actions/checkout@v4

      - name: DNSControl Check
        working-directory: ${{ github.workspace }}/dns
        run: dnscontrol check

Hope this helps 🙂 .