koenvervloesem / BTHome-Kaitai-Struct

BTHome format description in Kaitai Struct
MIT License
1 stars 0 forks source link

Add support for latest field types #3

Open seime opened 2 weeks ago

seime commented 2 weeks ago

Hi, thanks for your work.

I'm implementing support for BTHome in openHAB, and I've noticed the following new fields are missing

0x53 - text sensor 0x54 - raw sensor 0x55 - volume storage

In addition device information fields are missing as well

Object id Property Data Type Example Result
0xF0 device type id uint16 (2 bytes) F00100 1
0xF1 firmware version uint32 (4 bytes) F100010204 4.2.1.0
0xF2 firmware version uint24 (3 bytes) F1000106 6.1.0
koenvervloesem commented 2 weeks ago

Hi Arne, thanks for using this format description as the base for your BTHome binding for openHAB!

I've added the missing types in a new release so it supports the latest BTHome specification: https://github.com/koenvervloesem/BTHome-Kaitai-Struct/releases/tag/v3.9.3

I've added a link to your project in my README. Can you also add a link to BTHome-Kaitai-Struct in your repository?

seime commented 2 weeks ago

Thanks for the prompt resolving of this issue.

I've added a link to this website, great work!

Last thing; I noticed you've used "lux" as the unit for illuminance. Isn't the correct SI unit "lx"? See https://en.wikipedia.org/wiki/Lux