search

koenvo / pyodide-http

Provides patches for widely used http libraries to make them work in Pyodide environments like JupyterLite
MIT License
78 stars 15 forks source link

add support for url parameters #7

Closed joemarshall closed 2 years ago

joemarshall commented 2 years ago

this implements the params argument in requests. It just adds url parameters in ?param=value format.

I'm using pyodide-http in my project, and I needed this, would be nice to upstream it so we can get from pypi.

I've also got some code for streaming http if you're in a web worker and cross origin isolated, I'll chuck that in as a PR next.

joemarshall commented 2 years ago

Just redid this that way round in the streaming branch. Have you had a chance to look at that yet? I can copy the changes into here if you want just to merge this.

joemarshall commented 2 years ago

this was fixed by the other pr. Deleting