search

koesie10 / fsuipc-node

Native Node module for interfacing with FSUIPC
MIT License
17 stars 14 forks source link

Changed casting for write offset. #30

Closed bgiorgio0506 closed 10 months ago

bgiorgio0506 commented 1 year ago

I have changed the casting for type Int64 from Int32Value to Int64Value. This casting was creating an issue while writing on Int64 offset types.

I have tested the code as part of the process of validating changes for another porject. Also to note the Typescript definitions are wrong for types Int64 and Uint64 as the function requires 4 arguments for those types and not 3 ( I will open a new PR for TS types).

bgiorgio0506 commented 1 year ago

Thanks! Could you also make the equivalent change on line 343 for uint64?

yes sure I will do it in the coming weeks ; )

bgiorgio0506 commented 1 year ago

@koesie10 you can merge if my changes satisfy your code standards

bgiorgio0506 commented 10 months ago

@koesie10 sorry for the delay I have reverted the yarn.lock file and removed the package-lock.json. I have answerd your previous question let me know if you need some more clarification

koesie10 commented 10 months ago

@bgiorgio0506 Thanks! I've cherry-picked your changes in #33 and made some additional changes such that the types are now correct.

koesie10 commented 10 months ago

@bgiorgio0506 This has been published in version v0.7.2.

bgiorgio0506 commented 10 months ago

@koesie10 thanks !