koesie10 / webauthn

Go package for easy WebAuthn integration
MIT License
164 stars 17 forks source link

AuthenticatorStore GetAuthenticator definition #14

Open udf2457 opened 2 years ago

udf2457 commented 2 years ago

I have a question about the definition of id in GetAuthenticator (https://github.com/koesie10/webauthn/blob/8626f9623b4b03a1fef679e1f8576174acdc6551/webauthn/user.go#L28)

Should this not state WebAuthCredentialID is the reference ID ? Since (I assume) Authenticator.WebAuthID is inherently the same as User.WebAuthID and thus by definition using WebAuthID be expected to return multiple authenticators (i.e. behavior of GetAuthenticators(user User) and the only way to retrieve one authenticator would be using WebAuthCredentialID.