search

kofi1995 / laravel-sagepay

Sagepay Integration for Laravel 5.x
10 stars 9 forks source link

Correct case for SagePayServiceProvider #1

Closed rolandsaven closed 8 years ago

rolandsaven commented 8 years ago

My production environment thrown a fatal error (worked on dev) due to the case mismatch.

You can either merge this request that corrects the name of the service provider or change the readme to include the correct class name as show below. 

Kofikwarteng\LaravelSagepay\SagepayServiceProvider::class

Thanks for the SagePay wrapper though, is saves me time on my current project. :+1:

kofi1995 commented 8 years ago

Hello rolandkal, sorry for the issue. I am quite new to Laravel development and I did not see that problem. If you are interested, you can help me out. I can add you as a contributor to the project so you write a test for me. Thanks a lot for bringing my attention to the issue

rolandsaven commented 8 years ago

Thanks for merging, can you please also push it to packagist?

I'm not a pro in Laravel either and currently very short of time, but I would be happy to help in a couple months.

kofi1995 commented 8 years ago

Hello,

I have connected my github account to packagist so as soon as I make a change on github, it pushes automatically.

Let me know when you are ready to help so I add you as a contributor. I am also a very busy person and being a student doesn't help either.