kofi1995 / laravel-sagepay

Sagepay Integration for Laravel 5.x
10 stars 9 forks source link

1.0.3 Release #9

Open Qubical opened 6 years ago

Qubical commented 6 years ago

The current release does not have the fix for the removal of the share() method and the switch to the singleton (https://github.com/kofi1995/laravel-sagepay/issues/4) and so when bringing in via composer fails.

The quick fix is to specify the dev-master branch. "kofikwarteng/laravel-sagepay": "dev-master",

Thanks for the package, been VERY helpful.

Cheers

xron89 commented 6 years ago

This does resolve the share() error however when you run the "php artisan vendor:publish --provider="Kofikwarteng\LaravelSagepay\SagepayServiceProvider" command it doesn't create the sagepay.php file

Edit - For anyone with the same problem, you can just copy & paste the sagepay.php located in the vendor files. This works

sheixt commented 5 years ago

Looks like the dev-master addresses other issues (such as the user of the deprecated mcrypt_encrypt function).

Would be great to know if/when the master branch will be updated with these patches. In the mean time I'd recommend amending the documentation so that it clarifies the supported version of Laravel.