search

kofigumbs / multi

Create custom, lightweight macOS apps from websites
GNU General Public License v3.0
1.29k stars 40 forks source link

Migrate from NotificationCenter to UserNotifications #112

Closed kofigumbs closed 1 year ago

kofigumbs commented 1 year ago

I'm trying to troubleshoot because I'm experiencing the same thing, no notifications from whatsapp.

I tried using alerts and banners, also have alwaysNotify set to true.

When I enable "Show in Notification Center", I see a stack of old notifications from a day and more ago but not the latest ones when I text myself on whatsapp.

At some point, Multi at least had notifications in the Notification Center but never showed any banner notifications. And then it stopped showing notifications in Notification Center and banners completely.

After rebooting the laptop, I saw a banner notification from whatsapp once. Subsequently I can hear a notification sound but not visible notification. Notification Center is showing the notifications though.

Originally posted by @vurtomatic in https://github.com/kofigumbs/multi/issues/86#issuecomment-1445393109

kofigumbs commented 1 year ago

@vurtomatic I moved your comment to a new issue to avoid notifying other users. Do you have notification problems in other Multi apps other than WhatsApp? Could you try testing with https://www.bennish.net/web-notifications.html, which should help you identify whether this is a WhatsApp issue or a Multi issue?

vurtomatic commented 1 year ago

Thank you for cleaning up and organizing the discussion @kofigumbs .

I tested the link by opening it up in Safari, I received notifications normally.

I tried a bit of trial and error and I think when I have old Multi notifications in Notification Center, the new/current notification banners stop appearing.

After clearing the old notifications from Notification Center, notification banners appear again.

I don't know if old notifications in Notification Center is actually preventing banners from appearing (other apps don't seem to have the exact same problem), but it's the only change I made (clearing old notifications from Notification Center) that's seems to bring the Multi notification banners back.

[EDIT: I think I can confirm it has something to do with Notification Center. I just received two Whatsapp messages so I should have two banner notifications. I only received one banner notification which also appears in Notification Center. The second banner notification never appeared.

I disabled Multi notifications from Notification Center (thinking that will get banner notifications to appear) but the behavior is the same, only one banner notification and nothing after.]

vurtomatic commented 1 year ago

I'm noticing the same behavior with SMS notifications.

kofigumbs commented 1 year ago

I still haven't been able to exactly reproduce your issue using a publicly accessible website—please let me know if you make any progress on that front. My latest theory is that WhatsApp is using the Notifications.renotify property, which isn't implemented in Multi.

I think this issue is sufficient motivation to migrate notifications to use non-deprecated APIs though. That should make any future debugging easier and more consistent with the latest online resources. I updated the issue title to reflect that.

kofigumbs commented 1 year ago

Closing since notifications were revamped in v3.0.0. Rereading this thread, it seems like there are environment-specific quirks at play, so I'm not sure how much more help I can provide. Please let me know if there's anything else I can help troubleshoot though.