some small perf improvements

kofigyan / StateProgressBar

Android library to realize the various states and transitions in a ProgressBar.

1.55k stars 234 forks source link

some small perf improvements #15

Closed connyduck closed 7 years ago

connyduck commented 7 years ago

please review I am not sure why the animator is started in setVisibility when the new visibility is not VISIBLE.

kofigyan commented 7 years ago

I will review this and get back to you. Thank you.

kofigyan commented 7 years ago

Hi @connyduck , l noted the changes to the FontManager class. I decided to cache the Typeface in HashMap because of this reported bug with the call of Typeface.createFromAsset(). Thanks again for this important pull request.

connyduck commented 7 years ago

Thanks for merging! We are in the process of optimizing our app, so I decided to have a look at its libraries as well. This helps a lot, thank you!

kofigyan commented 7 years ago

You're welcome.