search

kofigyan / StateProgressBar

Android library to realize the various states and transitions in a ProgressBar.
1.55k stars 234 forks source link

Change AllowBackup from Manifest #19

Closed pacdouglas closed 7 years ago

pacdouglas commented 7 years ago

I'm in a project that goes through a security and vunerability tool which one of the requirements is the flag "AllowBackup" of the manifest file to have the value "false". I forked your project and changed that flag. Thanks a lot! I'm also making this "Pull Request" in case you find it interesting and want to make it default so people don't have this problem again.

connyduck commented 7 years ago

yes this is a good idea, please merge it @kofigyan And you should probably put *.iml files and files under .idea into gitignore :)

pacdouglas commented 7 years ago

Ye, sorry about *iml and .idea files ^_^

ligol commented 7 years ago

There is no need for an application tag in the manifest, could be better to simply delete it, what do you think?

kofigyan commented 7 years ago

Thank you @pacdouglas , @connyduck and @ligol and sorry about the delay in response. I am currently looking at this PR and will merge soon.

ligol commented 7 years ago

Merging the #3 PR will fix this issue by the way

kofigyan commented 7 years ago

Is merged now. Thanks once again @pacdouglas , @connyduck and @ligol .