coerce formdata openapiv3

kogosoftwarellc / open-api

A Monorepo of various packages to power OpenAPI in node

MIT License

892 stars 235 forks source link

coerce formdata openapiv3 #711

Closed chadxz closed 3 years ago

chadxz commented 3 years ago

openapi-request-coercer: Support oapiv3 formdata

In OpenAPI v3, formData requests are specified using the 'application/x-www-form-urlencoded' content-type inside the requestBody section of the operation. This commit adds support for coercing those formData parameters.
openapi-framework: Pass requestBody to coercer

In OpenAPIv3, formData is specified as a part of the requestBody field of the operation. This commit passes the requestBody to the coercer so that it can pull the formData parameters out and coerce them.

Related to #710.

chadxz commented 3 years ago

I'm having trouble getting this PR pulled into my actual application to verify that it is working as expected in a real-world app. Do you have any suggestions for doing that?

chadxz commented 3 years ago

added express-openapi and koa-openapi tests. I cherry-picked those tests off onto master and verified that without this change they failed, and with this change they passed.

chadxz commented 3 years ago

Hey @jsdevel, is anything still missing here?

jsdevel commented 3 years ago

thank you @chadxz !

chadxz commented 3 years ago

@jsdevel Thanks so much for your attention. Please let me know when you've released this stuff and I'll pull in and verify in my application that needed this.

chadxz commented 3 years ago

Verified this did fix my issue 🎉

jsdevel commented 3 years ago

Verified this did fix my issue

awesome sauce!!! thanks for fixing it!