kogosoftwarellc / open-api

A Monorepo of various packages to power OpenAPI in node
MIT License
895 stars 237 forks source link

openapi-type: strictly define `ResponsesObject` type #743

Closed mirceanis closed 3 years ago

mirceanis commented 3 years ago

fixes #742

This PR enables strict mode for typescript. Impressively, the project only has one issue that doesn't work in strict mode, and this PR also fixes that. You can check this quickly by running npx lerna run prepare which eventually runs tsc.

Strict mode (and this fix) is required by our project which depends directly on openapi-types, so your review of this and eventual release is much appreciated.

floriank commented 3 years ago

Thank you for this PR <3

I don't wish to be pushy - but I could really use this change as this currently blocks a project of mine. Any possible ETA on the next release?

jsdevel commented 3 years ago

@mirceanis please update with the latest from master.

mirceanis commented 3 years ago

@mirceanis please update with the latest from master.

I've rebased my changes onto the latest master Please re-review

Morl99 commented 3 years ago

We would also love to get this issue fixed. Is there anything we could do to help?

Kosta-Github commented 3 years ago

ping... any updates on this?