Would you be open to a PR to restore them?
It's pretty much done on my side, only the without-basePath tests need a few changes in addition to enabling sample-projects.ts to load all the tests in mocha.
Bonus, should all the tests w/ express be transposed for koa?
It's kind of needed to enable my next contributions to be tested against koa:
Restore security middleware order (#286, koa has been forgotten)
Forward rejection from security middleware (#603)
Fix initialize options typescript types (most of them should be optional as in express-openapi)
[openapi-request-validator] componentSchemas not used to validate body (#280 says it was fixed, but it seems not, i'll triple-check again before submitting, i didn't update for years until this week)
[openapi-security-handler] run securityHandlers serially, short-circuit on first positive result, continue after first Error & return it if all handlers fail (#728)
medfreeman
commented
3 years ago
Hi & thanks again for the great work!
At last i'm able to contribute back.
While preparing the PR for issue #286 for koa, i noticed that the tests in
sample-projectsfolder for koa are not run. Only the top-leveltest/sample-projectsare run atm: https://github.com/kogosoftwarellc/open-api/blob/24d87763c621f0886d02dbe96b20364055c46125/packages/koa-openapi/test/sample-projects.tsWould you be open to a PR to restore them? It's pretty much done on my side, only the
without-basePathtests need a few changes in addition to enablingsample-projects.tsto load all the tests in mocha.Bonus, should all the tests w/ express be transposed for koa?
It's kind of needed to enable my next contributions to be tested against koa:
componentSchemasnot used to validate body (#280 says it was fixed, but it seems not, i'll triple-check again before submitting, i didn't update for years until this week)Error& return it if all handlers fail (#728)We use https://github.com/ds300/patch-package to keep things sane, but it's time to merge back :)
Thanks!