Closed rokoucha closed 1 year ago
According to the docs, the backslash path delimiter is not supported by glob since 8.x. And we can confirm that 8.x is not working in projects using openapi-framework anymore so maybe we should lock the version to 7.x?
As far as I have tried, it works fine with glob 8.x.
Paths are returned in the canonical formatting for the platform in question. https://github.com/isaacs/node-glob/blob/main/changelog.md#90
I think this change may have destroyed it.
@rokoucha plz fix the build
@jsdevel I fixed it. It seems that it was originally unstable, not broken by my change.
A better option to fix this issue might be to change file
on this line to path.posix.normalize(file)
which will avoid dependency on a specific glob version (though I haven't tested this fix on a Windows machine, someone will need to do that first)
@rokoucha i agree with @meyerds . locking down a dependency potentially opens up this project to dep lock in and security vulnerabilities in the long wrong. can you try fixing it with the latest glob?
OK, I will close this PR and try to fix it with a new PR. thanks for the comments!
Since the combination of fs-routes and glob 9 or later stopped working on windows, I changed it to explicitly support up to glob 8.
https://github.com/isaacs/node-glob/blob/main/changelog.md#90