koh1project / apprenticeship_to_master

Apache License 2.0
0 stars 0 forks source link

Features #44

Closed koh1project closed 2 years ago

koh1project commented 2 years ago

What I have done

What I had already known

What I have acquired this week

closes #42 #41 #43

kei95 commented 2 years ago

@koh1project I'm confused by the commit history and this PR. Would you create a different PR for your changes? I don't think it's a good idea to reopen closed PR and add changes to it. You can even create different branches for each change as it's not realistic to review thousands of lines at once. Make sure not to open a big PR since that would increase the chance to slip errors in. It's pretty important to keep your PR easy to review because of it

koh1project commented 2 years ago

@kei95 I am sincerely sorry for making confusion. I made 2 mistakes, forgot to merge on the browser, and used the same branch name, resulting in this PR page unintentionally containing additional changes including the newest PR's changes. I will make sure such things never happen again.

kei95 commented 2 years ago

@kei95 I am sincerely sorry for making confusion. I made 2 mistakes, forgot to merge on the browser, and used the same branch name, resulting in this PR page unintentionally containing additional changes including the newest PR's changes. I will make sure such things never happen again.

No need to apologize!