Mood icons appear above the wrong place when using objects

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Member of staff has a mood icon when going to sit in the staff room
(most likley tierd mood)
2. Icon jumps to the hover over the right seat instead of remaining above
the member of staff (who is sat on the left)

What version of the product are you using? On what operating system?
r162

Original issue reported on code.google.com by chris_lo...@hotmail.com on 8 Dec 2009 at 12:14

[GoogleCodeExporter]

I see two problems here:

- staff is supposed to lose their "tired" mood as soon as they enter a staff 
room.
This does happen if they go in normally, but doesn't if they're dropped in.

- nevertheless, the cause of the mood icon appearing over the wrong spot must be
fixed, since it also causes other bugs: the little window in the staff dialog 
is also
centered on the wrong spot.

I'm working on it.

Original comment by roujin.mw on 8 Dec 2009 at 1:54

• Changed state: Started

[GoogleCodeExporter]

Original comment by roujin.mw on 8 Dec 2009 at 1:54

[GoogleCodeExporter]

Issue 97 has been merged into this issue.

Original comment by cor...@gmail.com on 25 Dec 2009 at 11:37

[GoogleCodeExporter]

Have you made any progress with this Roujin?

I expect that the solution to this will have to be constructing a database of 
"person
markers" for each animation, perhaps looking something like:

local ABD = TheAnimationDatabase -- Alias some global called 
TheAnimationDatabase
ABD:setMarker(56, "linear", {0, 0}, {-1, 0}) -- On animation 56, the person 
marker
moves from tile (0, 0) to tile (-1, 0) over the course of the animation.
ABD:setMarker(72, {-1, 0}) -- On animation 72, the person is always on tile 
(-1, 0)
ABD:setMarker(182, "frame-by-frame", {x0, y0}, {x1, y1}, {x2, y2}, ...) -- On
animation 182, the marker should be offset from the default position by {x0, y0}
pixels on the frame 0, {x1, y1} pixels on frame 1, etc.
ABD:setMarker(463, "linear", {0, 1}, {0, 0}) -- On animation 463, the primary 
user
moves from (0, 1) to (0, 0)
ABD:setSeconaryMarker(463, {-1, 1}) -- On animation 463, the secondary user 
remains
on tile (-1, 1)

There is also the issue of ensuring that the mood is always drawn on top of the
entity, but that should be trivial.

Original comment by cor...@gmail.com on 25 Dec 2009 at 11:51

[GoogleCodeExporter]

Hum, I did not think of such an elaborate solution as you're describing. I only
thought of fixing the mood icon (and viewport) being on the wrong tile, not the 
fact
that it's statically on that tile (instead of moving with the humanoid as he's
sitting down / standing up).

Actually at some point I stopped working on this. I now picked it up and 
brought it
to a (half) working state. I'm attaching it here as a patch so you can see what 
I was
thinking of. No guarantee of being bug-free though; plus the patch is against a
rather old revision (r164)..
Basically, I just planned to add a "mood (and viewport) offset" property to 
object
orienation definitions. This would then be used to place the mood icon and the
viewport in the right spot.

If you want to do something more elaborate like you described, feel free to use 
(or
not use, as you see fit) my patch as a base. Seeing that you've put much more 
thought
in this than I have, I'll better leave this to you.

Original comment by roujin.mw on 25 Dec 2009 at 4:47

[GoogleCodeExporter]

..forgot to attach patch.

Original comment by roujin.mw on 25 Dec 2009 at 4:48

Attachments:

• moodicon_wip2.diff

[GoogleCodeExporter]

I'm going down the elaborate route, with r262 being the first step.

Original comment by cor...@gmail.com on 26 Dec 2009 at 12:44

[GoogleCodeExporter]

Is the new way of doing it going to stay roughly the way it is? Because then I 
will
continue to use it just as I did with toilets.

Original comment by edvin.li...@gmail.com on 13 Jan 2010 at 2:35

[GoogleCodeExporter]

I think the current way of doing it will remain roughly the same, though see 
r360 for
a slight change in how to set multiple markers.

Original comment by cor...@gmail.com on 16 Jan 2010 at 1:24

[GoogleCodeExporter]

The original issue was fixed in revision 370, but since almost all other 
objects need
these adjustments too I'll let the issue be open.

Original comment by edvin.li...@gmail.com on 29 Jan 2010 at 10:30

[GoogleCodeExporter]

Issue 1207 has been merged into this issue.

Original comment by mark.l1...@hotmail.co.uk on 8 Apr 2012 at 8:01

[GoogleCodeExporter]

Original comment by mark.l1...@hotmail.co.uk on 8 Apr 2012 at 8:02

• Changed title: Mood icons appear above the wrong place when using objects

[GoogleCodeExporter]

Issue 1202 has been merged into this issue.

Original comment by edvin.li...@gmail.com on 31 Jan 2013 at 9:33

[GoogleCodeExporter]

Issue 1266 has been merged into this issue.

Original comment by edvin.li...@gmail.com on 1 Feb 2013 at 10:00

[GoogleCodeExporter]

Sorry Corsix, I've done this because you're not very active anymore in the 
project.

Original comment by maartenp...@hotmail.nl on 1 Apr 2013 at 2:53

[GoogleCodeExporter]

Fine by me :)

Original comment by cor...@corsix.org on 1 Apr 2013 at 5:58

[GoogleCodeExporter]

I did notice in TH that the emergency icon disappears as soon as the patient 
gets close to the inflator (which was in issue 1202).

Could this be an option for us, i.e. remove some of these icons when an object 
is being used? 

Original comment by mark.l1...@hotmail.co.uk on 8 Nov 2013 at 8:32

[GoogleCodeExporter]

Transferred to our github account end of 2014

https://github.com/CorsixTH/CorsixTH

Original comment by mark.l1...@hotmail.co.uk on 24 Dec 2014 at 5:27

• Changed state: Done