Use of mikey179/vfsStream for Log tests breaks module builds

[acoulton]

563 introduced a composer require-dev for mikey179/vfsStream to allow virtual filesystem tests of the log writers.

Unfortunately this breaks the builds for the other modules (eg https://travis-ci.org/kohana/image/jobs/97191751) because those builds include all the kohana/core tests (to check the module hasn't broken anything in core, I guess) but don't pick up the require-dev dependency from this package. Similarly, the kohana/kohana build is also going to fail for the same reason.

I think the best solution is to require mikey179/vfsStream in kohana/unittest - the same way we handle phpunit, so it's always present in development environments for any module that has a require-dev on kohana/unittest.

Alternatively we could modify the test suite to check if vfsStream is present and skip those tests if not.

Thoughts?

[enov]

I think the best solution is to require mikey179/vfsStream in kohana/unittest - the same way we handle phpunit, so it's always present in development environments for any module that has a require-dev on kohana/unittest.

:+1: that's the practical solution.

[rjd22]

:+1:

[acoulton]

Fixed by kohana/unittest#60