search

kohana / core

Core system classes from Kohana
http://kohanaframework.org
635 stars 327 forks source link

Fix uri with falsey strings eg '/0' [fixes kohana/kohana#94] #664

Closed acoulton closed 8 years ago

acoulton commented 8 years ago

Calling (new Request('/0'))->uri() should return '0' but was previously returning '/' because the '0' was incorrectly treated as empty.

Note that this is in part because Request::_construct always trims the leading '/' from internal requests - the previous comment implies the original intention was just to remove trailing '/' so this may not actually be desired but has been standard Kohana behaviour for a long time.

Thanks to @sergiozia for the report and proposed patch in kohana/kohana#94

Amended the comment to clarify.

enov commented 8 years ago

Thanks @acoulton, @sergiozia.