Patch Valid::ip to work with PHP v7.0.10+ AND v5.6.25+

kohana / core

Core system classes from Kohana

http://kohanaframework.org

635 stars 327 forks source link

Patch Valid::ip to work with PHP v7.0.10+ AND v5.6.25+ #699

Closed enov closed 8 years ago

enov commented 8 years ago

In a breaking change, https://github.com/php/php-src/pull/1954 added FILTER_FLAG_NO_PRIV_RANGE to FILTER_FLAG_NO_RES_RANGE.

The patch looks awful. Let me know if there is any better way to fix this.

Cheers!

rjd22 commented 8 years ago

@enov I'm missing tests if possible. :)

enov commented 8 years ago

Thanks for reviewing @rjd22. Kindly note that the tests are failing already, as PHP v7.0.10+ AND v5.6.25+ introduced the breaking bug fixes in those minor versions.

see for example https://github.com/kohana/core/pull/698

Thanks again.

enov commented 8 years ago

Please do not merge this, as it might be solved in the next minor versions of PHP https://github.com/php/php-src/pull/2113

enov commented 8 years ago

Fixed in PHP.