search

kohana / database

A Kohana module for database interactions, building queries, and prepared statements
http://kohanaframework.org/documentation
158 stars 140 forks source link

Added MySQLi Support #29

Closed kohenkatz closed 12 years ago

kohenkatz commented 12 years ago

This is the same as my previous pull request (27) but now really targeted against 3.3/develop.

See http://dev.kohanaframework.org/issues/3898

rjd22 commented 12 years ago

The issue number: http://dev.kohanaframework.org/issues/3898#change-15636

Kohana-Builds commented 12 years ago

Build Scheduled

Kohana-Builds commented 12 years ago

Build Failed
http://ci.kohanaframework.org/job/kohana-3.3-pull/47/

kiall commented 12 years ago

!build

We had some failing tests in the core code that triggered this failure.

Kohana-Builds commented 12 years ago

Build Scheduled

Kohana-Builds commented 12 years ago

Build Passed
http://ci.kohanaframework.org/job/kohana-3.3-pull/51/

ricardovf commented 12 years ago

This is good and should be default.

timaelliott commented 12 years ago

Is there any particular reason you call _select_db() in the connect() instead of just passing it as the 4th parameter to mysqli_connect? It's an additional query ("use db") that could simply be issued at the time of connection instead.

kohenkatz commented 12 years ago

@timelliott Simply because I copied it directly from the MySQL version and changed as little as necessary. I am sure that improvements can be made in readability and efficiency but this pull request is the 1st step on the way.

timaelliott commented 12 years ago

Okay, cool. We're already using this in production, great work so far!

yakatz commented 12 years ago

Any chance of this being merged soon?

kohenkatz commented 12 years ago

Closing in favor of my brother's pull request #37 with PSR-0 compliant file names.