Closed kohenkatz closed 12 years ago
The issue number: http://dev.kohanaframework.org/issues/3898#change-15636
Build Scheduled
!build
We had some failing tests in the core code that triggered this failure.
Build Scheduled
This is good and should be default.
Is there any particular reason you call _select_db() in the connect() instead of just passing it as the 4th parameter to mysqli_connect? It's an additional query ("use db") that could simply be issued at the time of connection instead.
@timelliott Simply because I copied it directly from the MySQL version and changed as little as necessary. I am sure that improvements can be made in readability and efficiency but this pull request is the 1st step on the way.
Okay, cool. We're already using this in production, great work so far!
Any chance of this being merged soon?
This is the same as my previous pull request (27) but now really targeted against 3.3/develop.
See http://dev.kohanaframework.org/issues/3898