search

kohana / database

A Kohana module for database interactions, building queries, and prepared statements
http://kohanaframework.org/documentation
158 stars 140 forks source link

Combine config reader and writer into a single class #71

Closed shadowhand closed 10 years ago

shadowhand commented 10 years ago

Without this change, it is nearly impossible to extend both the reader and writer. I have no idea what the author was thinking (teehee) because this class is definitely cannot be extended as written.

It also allows for using something other than serialize for encoding and decoding config values by exposing protected _encode and _decode methods that can be modified by extensions.

enov commented 10 years ago

@shadowhand sorry to close, maybe you want to target this towards 3.4/develop?

shadowhand commented 10 years ago

I don't, this affects 3.3 too.

enov commented 10 years ago

Alright, if this is a bug and this is the way it should be fixed, then probably it should go to 3.3/develop?

shadowhand commented 10 years ago

See #77