search

kohana / minion

Everyone loves having a minion they can boss around
113 stars 76 forks source link

Deprecated binary notice #35

Closed ThePixelDeveloper closed 6 years ago

ThePixelDeveloper commented 13 years ago

Have the binary pass in a minion version number. If that doesn't match with the source code then issue a notice telling the user to copy over the new binary.

Useful feature for future upgrades imho.

BRMatt commented 13 years ago

Personally I think it's easier to just use a symlink to the bash script shipped with the module. Thoughts?

ThePixelDeveloper commented 13 years ago

Yep, that is good too. This ticket is more about informing the user of a newer binary if one exists.

zeelot commented 13 years ago

the symlink isn't really an option for developers because they can't commit that to the repo. Everyone that works on the project would need to make the symlink, no?

BRMatt commented 13 years ago

Symlinks can be committed just fine

zeelot commented 13 years ago

I guess I don't know what happens when a windows user pulls that change in.