Feature/cleanup

[zeelot]

Just trying to clean things up and match a little closer to what they used to be.

• Removed last Util methods. Had to keep a couple static ones for now but at least they are all in Minion_Task where they belong
• Validation method for valid options was also moved to Minion_Task as it's not useful anywhere else
• $_options is now a $option => $default array and defines the accepted options
• Moved static method/property order to match all our other code (we should discuss official conventions)
• Removed any left over notion of config since everything is options now

[zeelot]

@kiall could you give this a quick look? I think I am ok with minion being released in this state (would like to get rid of more static functions down the road)

[Kohana-Builds]

Build Scheduled

[Kohana-Builds]

Build Failed
http://ci.kohanaframework.org/job/kohana-3.3-pull/64/

[zeelot]

Guess I'll try fixing the build tomorrow ;) probably broken unit tests

[kiall]

Re the build failure.. From http://ci.kohanaframework.org/job/kohana-3.3-pull/64/consoleFull

PHP Fatal error:  Class 'Minion_Util' not found in /var/lib/jenkins/jobs/kohana-3.3-pull/workspace/modules/minion/tests/minion/util.php on line 48

Re the pull itself.. Looks good. Let's get this merged once the tests are sorted :)

[zeelot]

!build

[Kohana-Builds]

Build Scheduled

[Kohana-Builds]

Build Failed
http://ci.kohanaframework.org/job/kohana-3.3-pull/71/

[Kohana-Builds]

Build Scheduled

[Kohana-Builds]

Build Passed
http://ci.kohanaframework.org/job/kohana-3.3-pull/72/

[biakaveron]

Task_Help class still uses Minion_Util.

[zeelot]

Thanks I'll take a look!

[biakaveron]

See https://github.com/kohana/minion/pull/55