search

kohana / minion

Everyone loves having a minion they can boss around
113 stars 76 forks source link

Should Minion_Cli::password have been removed from 3.4? #99

Open acoulton opened 10 years ago

acoulton commented 10 years ago

When resolving conflicts from 3.3/develop to 3.4/develop for #98 I found that f9f4d47 removed the Minion_CLI::password method from 3.4/develop. This commit was authored by @WinterSilence and appears to have been merged by @kemo in #92 - but I have not been able to find much detail in either the PR or commit message to identify why this was, or indeed whether it was intentional as the vast majority of the rest of that commit is just comment formatting and documentation.

There were bugfixes to that method in 3.3, so if it does need to be reinstated in 3.4 they'll need to be applied.

kemo commented 10 years ago

Tbh I don't know what happened there, that commit has been merged manually in favour of another PR being opened to fix the rest.

@WinterSilence why has Minion_CLI::password() been removed?

WinterSilence commented 10 years ago

@kemo wscript not supported by most hosts, function shell_exec not work in safe mode. someone from the developers use this method? these are not the main methods can be put in a separate class