search

kohana / ohanzee-helpers

Other
56 stars 10 forks source link

Aded Data Helper and Session Helper #12

Open ericuldall opened 9 years ago

ericuldall commented 9 years ago

These are two objects I find myself using a lot. I feel like the Class Name "Data" might be a bit too generic and would advise an alternate name, nothing came to mind right away.

shadowhand commented 9 years ago

It would be really helpful if these new classes came with phpspec tests.

ericuldall commented 9 years ago

Sounds good to me. I'll get some setup.

ericuldall commented 9 years ago

Also, just reviewed the psr-2 spec and realized I have some solid changes to make. Should be up to spec in a day or two.

ericuldall commented 9 years ago

I think I've addressed all of your concerns from the last code review. I still need to get on some phpspec tests, though.

rjd22 commented 8 years ago

@shadowhand it would be possible to merge this and make a ticket for tests.

shadowhand commented 8 years ago

It should be composed of two commits, not 26. And it needs tests.