Closed WinterSilence closed 10 years ago
Too many things happening in this PR. Please separate the simple change of Cookie::$separator
from the HMAC stuff and submit that as a second PR.
how to share this PR? I've never done this
You will need to rebase and possibly use cherry-pick.
Cookie::$separator
, it will easily change the value if necessaryCookie::$hash_hmac
andCookie::$hash_hmac_algo
properties, they used inCookie::salt()
for generate secure salt.Why not alter the class in a singleton? Access to variables must be accessed through methods rather than directly, it would prevent their values. Example: