search

kohana / ohanzee-helpers

Other
56 stars 10 forks source link

Arr: epic fails :) #8

Closed WinterSilence closed 9 years ago

WinterSilence commented 10 years ago

PHP 5.4: Call-time pass by reference has been removed https://github.com/kohana/ohanzee-helpers/blob/master/src/Arr.php#L205 https://github.com/kohana/ohanzee-helpers/blob/master/src/Arr.php#L346

PHP function range does same and more convenient. https://github.com/kohana/ohanzee-helpers/blob/master/src/Arr.php#L249

Invalid typo (non PSR-2). https://github.com/kohana/ohanzee-helpers/blob/master/src/Arr.php#L422

When I offered to do it, was refused :) It's valid for Arr::get(), but not for Arr::merge() and etc. https://github.com/kohana/ohanzee-helpers/blob/master/src/Arr.php#L98

shadowhand commented 9 years ago

PHP 5.4: Call-time pass by reference has been removed

Nothing in Arr uses call-time reference, we only use argument references, which are not the same thing.

PHP function range does same and more convenient.

Fixed.

Invalid typo (non PSR-2).

Not sure what this referring to, as I don't see any PSR-2 warnings currently.