search

kohana / orm

Kohana ORM
159 stars 108 forks source link

Fix for empty primary keys in create method #45

Closed hkdobrev closed 10 years ago

hkdobrev commented 13 years ago

The create method will check if the primary key is set, but will not check whether it is empty. The ORM should not allow empty primary keys. I have added a check against empty primary key.

Kohana-Builds commented 13 years ago

Build Starting
http://ci.kohanaframework.org/job/kohana-3.2-pull/53/

Kohana-Builds commented 13 years ago

Build Passed
http://ci.kohanaframework.org/job/kohana-3.2-pull/53/

kemo commented 10 years ago

Closing as the "adjusted" condition in this pull request will never be true as far as I can tell. Let me know if you think otherwise and I will reopen this.