search

kohana / orm

Kohana ORM
159 stars 108 forks source link

Update ORM.php #84

Closed aqlx86 closed 11 years ago

aqlx86 commented 11 years ago

i think this force_login() method should return something

Sebjugate commented 11 years ago

Agreed. I came to the exact same conclusion.

zeelot commented 11 years ago

Can't merge PRs into master branches, you should file a ticket and get this done in 3.4/develop (probably not a minor release).

tommcdo commented 11 years ago

I feel like this should actually go into all releases. It's clearly a bug. The doc says @return boolean, and without a return value, there's no sensible way to detect whether force_login() was successful.

zombor commented 11 years ago

That's fine. The point is we don't merge bug fixes directly to master. We have a release process.

tommcdo commented 11 years ago

Agreed. I'm commenting on @Zeelot's suggestion to file a ticket against 3.4/develop instead of against a minor release. If it were a feature request, then 3.4 would be an appropriate target, but this is a bug and should be fixed on all releases. It's documented to do something but it does not do it. (Compare to Auth_File->force_login().)