Update french.yml - Githubissues

koheiw commented 2 years ago

Add "Saigon" and add pattern without "City" for #47

ClaudeGrasland commented 2 years ago

Hi Kohei,

Yes "Saïgon" was the name of Hô Chi Minh Ville and many people forgot the double point on, writing "Saigon" insteda of "Saïgon"

koheiw commented 2 years ago

Hi @ClaudeGrasland. If you are fine this change, I will merged this to the maser. Please let me know.

ClaudeGrasland commented 2 years ago

Dear Kohei,

Yes, the proposed change is fine for me. But if you are interested, I will send you in a near future a completely revised version of the french dictionary based on a different approach where te aim is to find not only states but also world regions and world organisations (which implies to eliminate many ambiguities and to avoir lower case tranasformations).

Best regards,

Claude

De: "Kohei Watanabe" @.> À: "koheiw/newsmap" @.> Cc: "Claude Grasland" @.>, "Mention" @.> Envoyé: Lundi 21 Février 2022 11:04:24 Objet: Re: [koheiw/newsmap] Update french.yml (PR #59)

Hi [ https://github.com/ClaudeGrasland | @ClaudeGrasland ] . If you are fine this change, I will merged this to the maser. Please let me know.

— Reply to this email directly, [ https://github.com/koheiw/newsmap/pull/59#issuecomment-1046687831 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AFCXXCD4S3MTALTPFTXYUUTU4IE2RANCNFSM5O5HXIEQ | unsubscribe ] . Triage notifications on the go with GitHub Mobile for [ https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 | iOS ] or [ https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub | Android ] . You are receiving this because you were mentioned. Message ID: <koheiw/newsmap/pull/59/c1046687831 @ github . com>

koheiw / newsmap

Update french.yml #59