search

koheiw / newsmap

Semi-supervised algorithm for geographical document classification
Other
58 stars 22 forks source link

Add the Ukrainian spelling for the capital of UA #66

Closed koheiw closed 2 years ago

koheiw commented 2 years ago

Add the capital of UA with the Ukrainian spelling (Kyiv) along with the (conventional) Russian spelling (Kiew).

@stefan-mueller and @giucarny , can you tell what are German and Italian words for Kyiv?

codecov[bot] commented 2 years ago

Codecov Report

Merging #66 (2aeb1bd) into master (645bf1a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files           4        4           
  Lines         205      205           
=======================================
  Hits          164      164           
  Misses         41       41

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 645bf1a...2aeb1bd. Read the comment docs.

giucarny commented 2 years ago

@stefan-mueller and @giucarny , can you tell what are German and Italian words for Kyiv?

Hi Kohei, the Italian word is Kiev.

stefan-mueller commented 2 years ago

The German words are Kiew and Kyjiw. See also: https://de.wikipedia.org/wiki/Kiew#Schreibweise

koheiw commented 2 years ago

Thank you both. It is interesting that the Italian did not change the spelling.

koheiw commented 2 years ago

@daiyamao and @eladseg , I believe we do not need to add new words for Arabic or Hebrew for Kyiv. Can you confirm?

eladseg commented 2 years ago

@daiyamao and @eladseg , I believe we do not need to add new words for Arabic or Hebrew for Kyiv. Can you confirm?

Yes, I checked it and it is fine!

daiyamao commented 2 years ago

I also checked and found it was not necessary to change it.