search

koheiw / proxyC

R package for large-scale similarity/distance computation
GNU General Public License v3.0
29 stars 6 forks source link

Bring back the hamming distance! #18

Closed rcannood closed 3 years ago

rcannood commented 3 years ago

Fairly straight forward PR: I added back the hamming distance and wrote a small test. Since proxy doesn't support computing the hamming distance, I compute it manually by sapply-sweeping over the input matrix.

Some minor fixes to the NEWS.md are also included.

codecov[bot] commented 3 years ago

Codecov Report

Merging #18 (1a2dce9) into master (66a5409) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   99.10%   99.11%   +0.01%     
==========================================
  Files           4        4              
  Lines         334      338       +4     
==========================================
+ Hits          331      335       +4     
  Misses          3        3
Impacted Files Coverage Δ
R/proxy.R 99.00% <100.00%> (ø)
src/pair.cpp 99.22% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 838a2e6...1a2dce9. Read the comment docs.