search

koheiw / proxyC

R package for large-scale similarity/distance computation
GNU General Public License v3.0
29 stars 6 forks source link

Address issue 20 #21

Closed koheiw closed 3 years ago

koheiw commented 3 years ago

Add use_nan argument for #20. simil(method = "correlation", use_nan = TRUE) will return NaN for vectors without variance.

I am happy to change the name of the argument if @rcannood can has a better idea.

codecov[bot] commented 3 years ago

Codecov Report

Merging #21 (750c5b9) into master (fde2242) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   99.11%   99.15%   +0.04%     
==========================================
  Files           4        4              
  Lines         338      355      +17     
==========================================
+ Hits          335      352      +17     
  Misses          3        3
Impacted Files Coverage Δ
R/proxy.R 99.04% <100.00%> (+0.04%) :arrow_up:
src/linear.cpp 98.78% <100.00%> (+0.09%) :arrow_up:
src/pair.cpp 99.25% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fde2242...750c5b9. Read the comment docs.

koheiw commented 3 years ago

@rcannood thank you for reviewing. I will update CRAN soon.