Issue 24

[koheiw]

Allow passing a dense matrix to x or y for #24.

[codecov[bot]]

Codecov Report

Merging #25 (7f2a990) into master (8f00c67) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   99.44%   99.45%           
=======================================
  Files           4        4           
  Lines         363      369    +6     
=======================================
+ Hits          361      367    +6     
  Misses          2        2           

Impacted Files	Coverage Δ
R/proxy.R	99.04% <100.00%> (-0.04%)	:arrow_down:
src/pair.cpp	100.00% <0.00%> (ø)
src/linear.cpp	100.00% <0.00%> (ø)
src/proxyc.h	97.67% <0.00%> (+0.05%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f00c67...7f2a990. Read the comment docs.

[koheiw]

It is failing the tests on Ububtu 18 devel only because of

Run rcmdcheck::rcmdcheck(args = c("--no-manual", "--as-cran"), error_on = "warning", check_dir = "check")
Error: Error in loadNamespace(x) : there is no package called ‘rcmdcheck’
Calls: loadNamespace -> withRestarts -> withOneRestart -> doWithOneRestart
Execution halted
Error: Process completed with exit code 1.

[kasperwelbers]

Hi @koheiw,

Is this a check on submitting to CRAN, or is this via the github workflow? I haven't worked with github workflows in R packages yet (but it seems pretty cool!).

Just by eyeballing the yaml, wouldn't it simply be a matter of adding install.packages('rcmdcheck') on line 71 before using it?

Or am I completely misunderstanding the issue?

[kasperwelbers]

Oh no, wait. It does try to install rcmdcheck, but fails when installing curl

Issue might be that libcurl4-openssl-dev is not installed. That also explains why it only fails on Ubuntu dev. I suppose this could be hacked into the yaml as well, but it seems this yaml is auto-generated, right?

[koheiw]

Hi @kasperwelbers the check is on Github Action, a new CI platform. The test environment are all defined in the yaml file, but I am using common template.

I thought libcurl4-openssl-dev could be the issue, but the yaml file for the rcmdcheck package dosen't have anything related:

https://github.com/r-lib/rcmdcheck/blob/master/.github/workflows/check-pak.yaml

It could be a temporary issue in the development version of R...

[koheiw]

YAML file from https://github.com/r-lib/actions/blob/master/examples/test-coverage.yaml fixed the problem! It actually does not test on very old Ubuntu 18.

[koheiw]

@kasperwelbers, can you review? My PR passed all the checks.

[koheiw]

I only updated the test setting the in YAML file, so no change in package itself. Thank you for reviewing. I will submit to CRAN soon.