search

koheiw / proxyC

R package for large-scale similarity/distance computation
GNU General Public License v3.0
29 stars 6 forks source link

Change for Matrix v1.4-2 or later #35

Closed koheiw closed 2 years ago

koheiw commented 2 years ago

Based on the email notice by the Matrix authors

As discussed in Martin's thread from Aug 12

Matrix 1.4-2 needs adaption in your CRAN package

as(, "dgCMatrix") has been _un_deprecated, and as(, "dMatrix") is actually not backwards compatible. So my recommendation above should really be revised. If you are sure that that 'x' and 'y' are traditional matrices, then you can do:

x <- as(x, "dgCMatrix") y <- as(y, "dgCMatrix")

If you don't know anything about 'x' and 'y', then use the following, which is safe and backwards compatible:

x <- as(as(as(x, "CsparseMatrix"), "generalMatrix"), "dMatrix") y <- as(as(as(y, "CsparseMatrix"), "generalMatrix"), "dMatrix")

codecov[bot] commented 2 years ago

Codecov Report

Merging #35 (e5ffdb0) into master (7037f36) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files           4        4           
  Lines         395      395           
=======================================
  Hits          393      393           
  Misses          2        2
Impacted Files Coverage Δ
R/proxy.R 99.07% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more