search

koheiw / proxyC

R package for large-scale similarity/distance computation
GNU General Public License v3.0
29 stars 6 forks source link

Fix symmetry testing #4

Closed rcannood closed 5 years ago

rcannood commented 5 years ago

This is a fix for #3. The first commit (db9f60f) add tests to verify whether proxyC produces the correct results, even when x and y have the same dimensionality. The second commit (7df91ee) fixes the problem by adding a boolean argument that allows to specify whether the output matrix will be symmetric.

rcannood commented 5 years ago

Thanks for merging #2! I merged koheiw/proxyC@master into my branch, in order to enable travis for this PR.

codecov-io commented 5 years ago

Codecov Report

Merging #4 into master will increase coverage by 0.3%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #4     +/-   ##
=========================================
+ Coverage   92.85%   93.16%   +0.3%     
=========================================
  Files           4        4             
  Lines         266      278     +12     
=========================================
+ Hits          247      259     +12     
  Misses         19       19
Impacted Files Coverage Δ
src/pair.cpp 83.65% <100%> (ø) :arrow_up:
R/proxy.R 98.68% <100%> (+0.24%) :arrow_up:
src/linear.cpp 98.41% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5921b6f...a36886a. Read the comment docs.