koheiw / proxyC

R package for large-scale similarity/distance computation
GNU General Public License v3.0
29 stars 6 forks source link

Remove rcppparallel #47

Closed koheiw closed 5 months ago

koheiw commented 5 months ago

This is a rather urgent upgrade of the package to avoid crashes caused by memory leaks (segment fault) in the old TBB library in RcppParallel. Since the package does not update the library, we need to link to the new version of the library ourselves.

The library is avaialble in rtools and windbuilder, so Windows users are not affected . Linux users need to install the library header themselves.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.52%. Comparing base (9b139ce) to head (ef2c1ae).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #47 +/- ## ======================================= Coverage 99.51% 99.52% ======================================= Files 4 5 +1 Lines 416 418 +2 ======================================= + Hits 414 416 +2 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rcannood commented 5 months ago

revdepcheck is ok!

── INSTALL ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── 2 versions ──
Installing CRAN version of proxyC
Installing DEV version of proxyC
── CHECK ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── 12 packages ──
✔ quanteda.textstats 0.96.4              ── E: 0     | W: 0     | N: 0                                                                                                              
✔ dynutils 1.0.11                        ── E: 0     | W: 0     | N: 0                                                                                                              
✔ applicable 0.1.0                       ── E: 1     | W: 0     | N: 0                                                                                                              
✔ LSX 1.4.0                              ── E: 0     | W: 0     | N: 1                                                                                                              
✔ seededlda 1.1.0                        ── E: 0     | W: 0     | N: 4                                                                                                              
✔ simona 1.0.10                          ── E: 0     | W: 1     | N: 2                                                                                                              
✔ scClassify 1.14.0                      ── E: 0     | W: 0     | N: 0                                                                                                              
✔ immcp 1.0.3                            ── E: 0     | W: 0     | N: 0                                                                                                              
✔ SimBu 1.4.3                            ── E: 0     | W: 0     | N: 2                                                                                                              
✔ simplifyEnrichment 1.12.0              ── E: 0     | W: 0     | N: 1                                                                                                              
✔ scMerge 1.18.0                         ── E: 2     | W: 0     | N: 0                                                                                                              
✔ scFeatures 1.3.2                       ── E: 0     | W: 1     | N: 2                                                                                                              
OK: 12                                                                                                                                                                            
BROKEN: 0
Total time: 1 hour
── REPORT ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Writing summary to 'revdep/README.md'
Writing problems to 'revdep/problems.md'
Writing failures to 'revdep/failures.md'
Writing CRAN report to 'revdep/cran.md'
koheiw commented 5 months ago

I will submit to CRAN. Thanks.