search

koheiw / proxyC

R package for large-scale similarity/distance computation
GNU General Public License v3.0
29 stars 6 forks source link

Address issue #5 #6

Closed koheiw closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #6 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   93.16%   93.18%   +0.02%     
==========================================
  Files           4        4              
  Lines         278      279       +1     
==========================================
+ Hits          259      260       +1     
  Misses         19       19
Impacted Files Coverage Δ
R/proxy.R 98.7% <100%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80fed0c...3272013. Read the comment docs.

kasperwelbers commented 5 years ago

Cool, I wasn't familiar with zapsmall. Anything you want me to review in particular? The code looks good to me.

rcannood commented 5 years ago

Me neither, TIL zapsmall. Hallo, by the way.

@koheiw: Thanks for fixing #5 so quickly!