Closed koheiw closed 2 years ago
Merging #27 (857f9f9) into master (d887712) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 98.76% 98.78% +0.02%
==========================================
Files 5 6 +1
Lines 243 247 +4
==========================================
+ Hits 240 244 +4
Misses 3 3
Impacted Files | Coverage Δ | |
---|---|---|
R/utils.R | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d887712...857f9f9. Read the comment docs.
@contefranz If you are happy with the divergence()
, please approve this PR.
@contefranz If you are happy with the
divergence()
, please approve this PR.
I am happy, but left a comment on it. How about adding a similar method for the seededlda method and not just the lda? If you want to split the work in two, I'll approve the PR. Just let me know.
I think I cannot see your comments until you click "Request change".
Thanks!
Add divergence() for #26 .