search

kohesive / vertx-sqs

Amazon SQS Client for Vert.x
MIT License
13 stars 13 forks source link

CredentialsProvider fallback #2

Closed meticoeus closed 6 years ago

meticoeus commented 8 years ago

Why is ProfileCredentialsProvider the fallback instead of DefaultAWSCredentialsProviderChain, which will reference the profile location as part of the chain?

DefaultAWSCredentialsProviderChain also includes InstanceProfileCredentialsProvider for easier configuration when deploying to EC2.

apatrida commented 6 years ago

We typically avoid environment variables and system properties so place a safe fallback that does not use those. Did you have a suggested difference, send a PR and I'll gladly look at it.

stoccoPismo commented 6 years ago

I have the same problem, can we use DefaultAWSCredentialsProviderChain() instead of the ProfileCredentialsProvider() method in the fallback? It is more secure than using accesskeys or aws configuration files in ec2. Please :)

Pr: https://github.com/kohesive/vertx-sqs/pull/5

apatrida commented 6 years ago

Released in BETA-02