Closed maxarndt closed 4 years ago
Hi @maxarndt, I think you become a contributor because I merged your PR. I sent invitation mail for collaborator.
I will review this PR later ! Looks cool for people who wants to generate PDF during build!
Thanks for reviewing, I will fix the typos.
Iām using Google Cloud Build as CI/CD runner. I could update the docs after the new version is released as npm package. Currently I have to :
git clone
the feature branchnpm install
npm run build
node
So I think it would be much more helpful to illustrate using this program with npx
instead with the four steps listed above.
I already figured out that special dependencies in the execution environment are required for puppeteer. Currently Iām using zenika/alpine-chrome:with-puppeteer image to run this CD step but there are still some issues to fix. I will further analyze this on Tuesday next week. I think it is helpful to suggest a docker image which runs the PDF generation without any problems.
Do you use any CI/CD tools to give it a try?
So I think it would be much more helpful to illustrate using this program with npx instead with the four steps listed above.
=> okay š
I will further analyze this on Tuesday next week
=> okay š
I think it is helpful to suggest a docker image which runs the PDF generation without any problems.
=> Thanks! š
Do you use any CI/CD tools to give it a try?
=> No. but I will try with Netlify.
So, I merge this PR and publish and try during build! Thanks!
Hey @KohheePeace!
At first thank you for adding me as a contributor. But unfortunately I'm not able to create/push a new branch directly to this repository. Is this by purpose or could you check the permissions?
This PR includes a feature which enables using this tool in a CD pipeline.
I added express to serve the previously built static files (normally by executing
npx docusaurus build
) and called yourgeneratePdf()
function afterwards.To support this functionality I added the
from-build
command tocommander
:What do you think about this feature?