search

kohheepeace / mr-pdf

Generate PDF for document website.
https://www.npmjs.com/package/mr-pdf
MIT License
125 stars 41 forks source link

QuerySelector check missing on page.evaluate #47

Open videki opened 2 years ago

videki commented 2 years ago

With docusaurus v2, autogenerated sidebars on the last page the selector gets empty, but the eval has no check for that:

` node:internal/process/promises:246 triggerUncaughtException(err, true / fromPromise /); ^

Error: Evaluation failed: DOMException: Failed to execute 'querySelectorAll' on 'Document': The provided selector is empty. at puppeteer_evaluation_script:3:46 at ExecutionContext._evaluateInternal (/Users/.../node_modules/puppeteer/lib/ExecutionContext.js:122:13) at processTicksAndRejections (node:internal/process/task_queues:96:5) at async ExecutionContext.evaluate (/Users/.../node_modules/puppeteer/lib/ExecutionContext.js:48:12) at async /Users/.../node_modules/mr-pdf/lib/utils.js:122:13 -- ASYNC -- at ExecutionContext. (/Users/.../node_modules/puppeteer/lib/helper.js:111:15) at DOMWorld.evaluate (/Users/.../node_modules/puppeteer/lib/DOMWorld.js:112:20) at processTicksAndRejections (node:internal/process/task_queues:96:5) -- ASYNC -- at Frame. (/Users/.../node_modules/puppeteer/lib/helper.js:111:15) at Page.evaluate (/Users/.../node_modules/puppeteer/lib/Page.js:860:43) at Page. (/Users/.../node_modules/puppeteer/lib/helper.js:112:23) at /Users/.../node_modules/mr-pdf/lib/utils.js:122:24 at Array.map () at Object.generatePDF (/Users/.../node_modules/mr-pdf/lib/utils.js:119:26) at processTicksAndRejections (node:internal/process/task_queues:96:5) `