kohinsky46 / js-test-driver

Automatically exported from code.google.com/p/js-test-driver
0 stars 0 forks source link

/quit handler should shut down the server immediately #432

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
When you hit the /quit endpoint, it starts a graceful shutdown of Jetty. This 
means that the process doesn't not actually terminate for another 60 secs. 
Given how JsTestDriver is used, this seems unnecessary to me. It would be 
better to just sever all connections and stop the process as soon as possible.

I ran into this because I was having problems killing the JsTestDriver server 
process on Windows when launching via the Java Process API. The process was not 
terminating because it was blocked in an accept() call deep in the Jetty code. 
Stopping the process via the /quit front door resolved the issue, but it added 
an extra minute to the build time for each jstestdriver process we needed to 
launch.

Original issue reported on code.google.com by l...@ldaley.com on 20 May 2013 at 2:11