kohkaijie / pe

0 stars 0 forks source link

App allows adding of same person but with one's name uncapitalised #2

Open kohkaijie opened 10 months ago

kohkaijie commented 10 months ago

Steps to reproduce:

  1. add n/John Doe p/81234567 e/John@gmail.com a/123 NUS Rd th/@johnny t/cf c/CS1231S c/CS2103T
  2. add n/John doe p/81234567 e/John@gmail.com a/123 NUS Rd th/@johnny t/cf c/CS1231S c/CS2103T

Expected result: App does not allow me to add duplicate persons

Actual result: Person with exact same details but with the Doe uncapitalised was able to be added

The app should be able to check that the same person was added as it is clear that John Doe and John doe are the same person.

image.png

nus-se-bot commented 9 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Case sensitive names

I can have duplicate names, one with lower case and one with upper case, in the contact list.

image.png

Shouldn't names be case-insensitive in the real world? The user guide says that duplicate students are identified by their names.

image.png


[original: nus-cs2103-AY2324S1/pe-interim#3286] [original labels: type.FeatureFlaw severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for pointing out the possibility of having two person with the same alphabet spelling in their name. However, in our User Guide, we have clearly stated that the name is case sensitive, so for our app, we assume that Ibrahim and ibrahim are two different students because of the case sensitive.

Based on this

Screenshot 2023-11-20 at 1.30.08 PM.png

Since our User Guide clearly stated that the name is case sensitive, hence, it is sad to say that we have chosen to reject this bug report.

Screenshot 2023-11-20 at 1.32.46 PM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/kohkaijie/pe/main/files/6f56dc33-bfb1-41e3-b3fe-1f4b3e4df664.png) In the snippet provided above taken from the CS2103T Course Website, it is clearly stated that `John Doe` and `john doe` are likely to be the same person. While it is stated in the UG that names are case sensitive and I do agree that that was stated clearly with no ambiguity, it does not change the fact that in a real-word scenario, an upper-case letter in a name does not cause it to differ from its original. Therefore, I believe this a feature flaw of the app with regards to the duplicate detection behaviour of the app not being comprehensive enough to prevent same names being added and henceforth, I disagree with the group's reasoning that it is not a bug.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** This is not a `severity.VeryLow` issue at it is not merely a cosmetic issue due to there being an upper-case. The main issue at hand here is regards with incomprehensive duplicate detection and the same person being able to be added while it is stated in the UG that it is not allowed. Therefore, I would like to argue that my original `severity.Low` is more accurate as it has more to do with a flaw with the app that occurs in rare scenarios.