search

kohkaijie / pe

0 stars 0 forks source link

App allows add-course to add same course for Edit Command #6

Open kohkaijie opened 11 months ago

kohkaijie commented 11 months ago

Steps to reproduce: edit 8 c/add-ma2001

Expected result: App informs user that the person already has the specified course

Actual result: Command is successful even though the course was not added

In the user guide, it was mentioned that when adding a course that the person already has, the course will not be added again. Therefore, I believed the app will throw an error to inform me that I am adding the same course, but it did not occur, and this behaviour was not specified in the user guide.

image.png

nus-se-script commented 11 months ago

Team's Response

Therefore, I believed the app will throw an error to inform me that I am adding the same course, but it did not occur, and this behaviour was not specified in the user guide.

  1. The user guide specifies that the "course will not be added again if the user already has the course". There is no mention that an error will be thrown in the UG if you try to add multiple of the same course. If it were mentioned in the UG that an error will be thrown upon adding multiple same courses, and we did not throw an error, then it would be a bug. In this case, we never mentioned that in the UG, hence this is not a bug.

  2. On the other hand, if a person does not originally have a course, we stated clearly that an error in the UG will be thrown.

We feel the assumption - if it is not stated in the UG that an exception will not be thrown, then it is understood that none will be thrown - is a reasonable one - stating that an exception will not be thrown after each successful command in the UG would be rather unwieldy to the reader.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While the UG did not mention that any error will be thrown if you try to add the same course, the fact that the expected behaviour differs from what is stated in the UG is still evident. The fact that the UG mentioned the course will not be added again is a clear indication to the user that you are not allowed to add the same course again, which I am able to do. While no error message was explicitly stated, it does not change the fact that the intended behaviour of the app differs from what is stated in the UG. Therefore, I disagree that this is not a bug.