return if pcap_activate fails

kohler / click

The Click modular router: fast modular packet processing and analysis

Other

740 stars 321 forks source link

return if pcap_activate fails #369

Closed larsbro closed 6 years ago

larsbro commented 7 years ago

If a Click process is started without enough privileges to start pcap on a device (usually root), a segmentation fault will happen, because FromDevice::open_pcap() does not return after pcap_activate() failing, but proceeds to pcap_setnonblock().

larsbro commented 6 years ago

Does not seem to pass tests. I will try another way